Discussion:
[PATCH] grub-install: Mention *efibootmgr* in no-nvram description
(too old to reply)
Paul Menzel
2018-09-06 13:54:47 UTC
Permalink
Date: Thu, 6 Sep 2018 15:15:45 +0200

If executing `efibootmgr` fails, for example, because the system is booted in
legacy mode, but with a mounted EFI System Partition, the error message
mentions *efibootmgr*. To make it easier for users to work around that
problem by skipping running `efibootmgr`, add the word to the description of
the switch *no-nvram*, which skips the efibootmgr execution.

---
util/grub-install.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/util/grub-install.c b/util/grub-install.c
index a44858198..335662a58 100644
--- a/util/grub-install.c
+++ b/util/grub-install.c
@@ -276,7 +276,7 @@ static struct argp_option options[] = {
N_("disk module to use (biosdisk or native). "
"This option is only available on BIOS target."), 2},
{"no-nvram", OPTION_NO_NVRAM, 0, 0,
- N_("don't update the `boot-device'/`Boot*' NVRAM variables. "
+ N_("don't run efibootmgr to update the `boot-device'/`Boot*' NVRAM variables. "
"This option is only available on EFI and IEEE1275 targets."), 2},
{"skip-fs-probe",'s',0, 0,
N_("do not probe for filesystems in DEVICE"), 0},
--
2.17.1
Paul Menzel
2018-09-06 14:02:52 UTC
Permalink
Date: Thu, 6 Sep 2018 15:15:45 +0200

If executing `efibootmgr` fails, for example, because the system is
booted in legacy mode, but with a mounted EFI System Partition, the
error message mentions *efibootmgr*. To make it easier for users to work
around that problem by skipping running `efibootmgr`, add the word to
the description of the switch *no-nvram*, which skips the efibootmgr
execution.

Signed-off-by: Paul Menzel <***@molgen.mpg.de>
---
v2: Add Signed-off-by line

util/grub-install.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/util/grub-install.c b/util/grub-install.c
index a44858198..335662a58 100644
--- a/util/grub-install.c
+++ b/util/grub-install.c
@@ -276,7 +276,7 @@ static struct argp_option options[] = {
N_("disk module to use (biosdisk or native). "
"This option is only available on BIOS target."), 2},
{"no-nvram", OPTION_NO_NVRAM, 0, 0,
- N_("don't update the `boot-device'/`Boot*' NVRAM variables. "
+ N_("don't run efibootmgr to update the `boot-device'/`Boot*' NVRAM variables. "
"This option is only available on EFI and IEEE1275 targets."), 2},
{"skip-fs-probe",'s',0, 0,
N_("do not probe for filesystems in DEVICE"), 0},
--
2.17.1
Vladimir 'phcoder' Serbinenko
2018-09-06 17:37:50 UTC
Permalink
Post by Paul Menzel
Date: Thu, 6 Sep 2018 15:15:45 +0200
If executing `efibootmgr` fails, for example, because the system is
booted in legacy mode, but with a mounted EFI System Partition, the
error message mentions *efibootmgr*. To make it easier for users to work
around that problem by skipping running `efibootmgr`, add the word to
the description of the switch *no-nvram*, which skips the efibootmgr
execution.
---
v2: Add Signed-off-by line
util/grub-install.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/util/grub-install.c b/util/grub-install.c
index a44858198..335662a58 100644
--- a/util/grub-install.c
+++ b/util/grub-install.c
@@ -276,7 +276,7 @@ static struct argp_option options[] = {
N_("disk module to use (biosdisk or native). "
"This option is only available on BIOS target."), 2},
{"no-nvram", OPTION_NO_NVRAM, 0, 0,
- N_("don't update the `boot-device'/`Boot*' NVRAM variables. "
+ N_("don't run efibootmgr to update the `boot-device'/`Boot*' NVRAM variables. "
"This option is only available on EFI and IEEE1275 targets."), 2},
In case of ieee1275 this has nothing to do with efibootmgr
Post by Paul Menzel
{"skip-fs-probe",'s',0, 0,
N_("do not probe for filesystems in DEVICE"), 0},
--
2.17.1
_______________________________________________
Grub-devel mailing list
https://lists.gnu.org/mailman/listinfo/grub-devel
Daniel Kiper
2018-09-19 14:08:21 UTC
Permalink
Post by Vladimir 'phcoder' Serbinenko
Post by Paul Menzel
Date: Thu, 6 Sep 2018 15:15:45 +0200
If executing `efibootmgr` fails, for example, because the system is
booted in legacy mode, but with a mounted EFI System Partition, the
error message mentions *efibootmgr*. To make it easier for users to work
around that problem by skipping running `efibootmgr`, add the word to
the description of the switch *no-nvram*, which skips the efibootmgr
execution.
---
v2: Add Signed-off-by line
util/grub-install.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/util/grub-install.c b/util/grub-install.c
index a44858198..335662a58 100644
--- a/util/grub-install.c
+++ b/util/grub-install.c
@@ -276,7 +276,7 @@ static struct argp_option options[] = {
N_("disk module to use (biosdisk or native). "
"This option is only available on BIOS target."), 2},
{"no-nvram", OPTION_NO_NVRAM, 0, 0,
- N_("don't update the `boot-device'/`Boot*' NVRAM variables. "
+ N_("don't run efibootmgr to update the `boot-device'/`Boot*' NVRAM variables. "
"This option is only available on EFI and IEEE1275 targets."), 2},
In case of ieee1275 this has nothing to do with efibootmgr
Paul, are you going to repost the patch with relevant change in the code
and commit message or should I fix it just before push?

Daniel
Paul Menzel
2018-09-19 14:18:45 UTC
Permalink
Dear Daniel,
Post by Daniel Kiper
Post by Vladimir 'phcoder' Serbinenko
Post by Paul Menzel
Date: Thu, 6 Sep 2018 15:15:45 +0200
If executing `efibootmgr` fails, for example, because the system is
booted in legacy mode, but with a mounted EFI System Partition, the
error message mentions *efibootmgr*. To make it easier for users to work
around that problem by skipping running `efibootmgr`, add the word to
the description of the switch *no-nvram*, which skips the efibootmgr
execution.
---
v2: Add Signed-off-by line
util/grub-install.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/util/grub-install.c b/util/grub-install.c
index a44858198..335662a58 100644
--- a/util/grub-install.c
+++ b/util/grub-install.c
@@ -276,7 +276,7 @@ static struct argp_option options[] = {
N_("disk module to use (biosdisk or native). "
"This option is only available on BIOS target."), 2},
{"no-nvram", OPTION_NO_NVRAM, 0, 0,
- N_("don't update the `boot-device'/`Boot*' NVRAM variables. "
+ N_("don't run efibootmgr to update the `boot-device'/`Boot*' NVRAM variables. "
"This option is only available on EFI and IEEE1275 targets."), 2},
In case of ieee1275 this has nothing to do with efibootmgr
Paul, are you going to repost the patch with relevant change in the code
and commit message or should I fix it just before push?
I am still thinking how to phrase it. Maybe, just add efibootmanager
after EFI?
Post by Daniel Kiper
don’t update the `boot-device'/`Boot*' NVRAM variables. This option
is only available on EFI (efibootmgr) and IEEE1275 targets.
Kind regards,

Paul
Daniel Kiper
2018-09-21 17:58:06 UTC
Permalink
Post by Paul Menzel
Dear Daniel,
Post by Daniel Kiper
Post by Vladimir 'phcoder' Serbinenko
Post by Paul Menzel
Date: Thu, 6 Sep 2018 15:15:45 +0200
If executing `efibootmgr` fails, for example, because the system is
booted in legacy mode, but with a mounted EFI System Partition, the
error message mentions *efibootmgr*. To make it easier for users to work
around that problem by skipping running `efibootmgr`, add the word to
the description of the switch *no-nvram*, which skips the efibootmgr
execution.
---
v2: Add Signed-off-by line
util/grub-install.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/util/grub-install.c b/util/grub-install.c
index a44858198..335662a58 100644
--- a/util/grub-install.c
+++ b/util/grub-install.c
@@ -276,7 +276,7 @@ static struct argp_option options[] = {
N_("disk module to use (biosdisk or native). "
"This option is only available on BIOS target."), 2},
{"no-nvram", OPTION_NO_NVRAM, 0, 0,
- N_("don't update the `boot-device'/`Boot*' NVRAM variables. "
+ N_("don't run efibootmgr to update the `boot-device'/`Boot*' NVRAM variables. "
"This option is only available on EFI and IEEE1275 targets."), 2},
In case of ieee1275 this has nothing to do with efibootmgr
Paul, are you going to repost the patch with relevant change in the code
and commit message or should I fix it just before push?
I am still thinking how to phrase it. Maybe, just add efibootmanager
after EFI?
What about "don't update, e.g. using efibootmgr, the `boot-device'/`Boot*' NVRAM variables. "?

Daniel

Continue reading on narkive:
Loading...