Discussion:
[PATCH] relocator16.S: comments update
(too old to reply)
Cao jin
2018-08-14 07:03:25 UTC
Permalink
Signed-off-by: Cao jin <***@cn.fujitsu.com>
---
grub-core/lib/i386/relocator16.S | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/grub-core/lib/i386/relocator16.S b/grub-core/lib/i386/relocator16.S
index c8d6f86d8..a8b48d2c4 100644
--- a/grub-core/lib/i386/relocator16.S
+++ b/grub-core/lib/i386/relocator16.S
@@ -204,8 +204,8 @@ LOCAL(gate_a20_check_state):
ret

LOCAL(gate_a20_done):
- /* we are in real mode now
- * set up the real mode segment registers : DS, SS, ES
+ /* we are in real mode now. Set up the real mode segment registers and
+ * all the other general purpose registers. cs is updated with ljmp.
*/
/* movw imm16, %ax. */
.byte 0xb8
@@ -298,7 +298,7 @@ LOCAL(gdt):
.byte 0, 0x92, 0xCF, 0

/* -- 16 bit real mode CS --
- * base = 0x00000000, limit 0x0FFFF (1 B Granularity), present
+ * base = filled by code, limit 0x0FFFF (1 B Granularity), present
* type = 16 bit code execute/read only/conforming, DPL = 0
*/
.word 0xFFFF
--
2.17.0
Daniel Kiper
2018-09-04 10:00:56 UTC
Permalink
Reviewed-by: Daniel Kiper <***@oracle.com>

Daniel

Continue reading on narkive:
Loading...