Discussion:
[PATCH] grub-setup: debug message cleanup
Cao jin
2018-07-03 10:51:13 UTC
Permalink
variable "root" is initialized after root device probing, and is null in
current place, so, drop it.

Signed-off-by: Cao jin <***@cn.fujitsu.com>
---
util/setup.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

BTW, I am still not very sure about "root device" in grub, is it the
partition where boot directory resides?

diff --git a/util/setup.c b/util/setup.c
index 8aa5a39a7..7d3bf2c27 100644
--- a/util/setup.c
+++ b/util/setup.c
@@ -298,9 +298,8 @@ SETUP (const char *dir,
bl.first_block = (struct grub_boot_blocklist *) (core_img
+ GRUB_DISK_SECTOR_SIZE
- sizeof (*bl.block));
- grub_util_info ("root is `%s', dest is `%s'", root, dest);

- grub_util_info ("Opening dest");
+ grub_util_info ("Opening dest `%s'", dest);
dest_dev = grub_device_open (dest);
if (! dest_dev)
grub_util_error ("%s", grub_errmsg);
--
2.14.3
Daniel Kiper
2018-07-04 14:46:36 UTC
Permalink
Post by Cao jin
variable "root" is initialized after root device probing, and is null in
current place, so, drop it.
Reviewed-by: Daniel Kiper <***@oracle.com>

If there are no objections I will apply this in a week or so.

Daniel

Continue reading on narkive:
Loading...