Discussion:
[PATCH] tests: Fix qemu options for UHCI test
(too old to reply)
Colin Watson
2018-07-30 11:37:42 UTC
Permalink
qemu 2.12 removed the -usbdevice option. Use a more modern spelling
instead, in line with other USB-related tests.

Signed-off-by: Colin Watson <***@ubuntu.com>
---
tests/uhci_test.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/uhci_test.in b/tests/uhci_test.in
index 4af72fd8f..f0eec5032 100644
--- a/tests/uhci_test.in
+++ b/tests/uhci_test.in
@@ -41,7 +41,7 @@ echo "hello" > "$outfile"

tar cf "$imgfile" "$outfile"

-if [ "$(echo "nativedisk; source '(usb0)/$outfile';" | "${grubshell}" --qemu-opts="-usb -usbdevice disk:$imgfile" | tail -n 1)" != "Hello World" ]; then
+if [ "$(echo "nativedisk; source '(usb0)/$outfile';" | "${grubshell}" --qemu-opts="-device ich9-usb-uhci1 -drive id=my_usb_disk,file=$imgfile,if=none -device usb-storage,drive=my_usb_disk" | tail -n 1)" != "Hello World" ]; then
rm "$imgfile"
rm "$outfile"
exit 1
--
2.18.0
Daniel Kiper
2018-09-04 14:22:29 UTC
Permalink
Post by Colin Watson
qemu 2.12 removed the -usbdevice option. Use a more modern spelling
instead, in line with other USB-related tests.
Reviewed-by: Daniel Kiper <***@oracle.com>

Daniel

Continue reading on narkive:
Loading...